-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lib): go back to monorepo with 2 packages #81
Conversation
README.md
Outdated
@@ -60,7 +62,7 @@ To generate the documentation, please run the following: | |||
|
|||
```bash | |||
cd docs | |||
pdm run make html | |||
pdm run make html # TODO: change me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
File types are normally capitalized. (FILE_EXTENSIONS_CASE[1])
Suggestions: HTML
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/FILE_EXTENSIONS_CASE?lang=en-US&subId=1
Category: CASING
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 86.71% 88.81% +2.10%
==========================================
Files 18 35 +17
Lines 572 1252 +680
==========================================
+ Hits 496 1112 +616
- Misses 76 140 +64 ☔ View full report in Codecov by Sentry. |
Rust benchmark results:
|
@@ -60,7 +78,7 @@ To generate the documentation, please run the following: | |||
|
|||
```bash | |||
cd docs | |||
pdm run make html | |||
make html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
File types are normally capitalized. (FILE_EXTENSIONS_CASE[1])
Suggestions: HTML
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/FILE_EXTENSIONS_CASE?lang=en-US&subId=1
Category: CASING
With Rye, it seems to be finally possible to have Python monorepos.
Currently, the layout would be
and publishing both packages, but I also consider doing
A few TODOs:
.readthedocs.yaml
to use Rye (or install the package correctly)differt
and differt-core`differt-core
via pre-built wheels for each platform anddiffert
one usingany-*
wheels)differt
anddiffert-core
(e.g.,graph
modules).gitignore
fileCargo.toml
for workspace (currently we have a warning)tests
folder fordiffert-core
?differt-core
differt-core
's README andpyproject.toml
file