Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] all_paths* methods from differt.rt.graph do not allow from_ to be a keyword argument #69

Closed
jeertmans opened this issue Mar 12, 2024 · 0 comments · Fixed by #81
Closed
Labels
bug Something isn't working

Comments

@jeertmans
Copy link
Owner

E.g., DiGraph.all_paths(from_=0, ...) does not work as the text signature (from_) differs from the true signature (from). This is an issue because from cannot be used in Python.

Possible solutions:

  • Create a wrapper in Python that maps keyword-arguments to positional arguments.
  • Make from_ and others explicitly positional-only parameters.
  • Rename from to from_ inside Rust code (at least in the function signatures).
@jeertmans jeertmans added the bug Something isn't working label Mar 12, 2024
@jeertmans jeertmans linked a pull request May 2, 2024 that will close this issue
13 tasks
@jeertmans jeertmans changed the title Bug - all_paths* methods from differt.rt.graph do not allow from_ to be a keyword argument [BUG] all_paths* methods from differt.rt.graph do not allow from_ to be a keyword argument Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant