Skip to content

Commit

Permalink
Update various xcconfig: suggested Clang warnings and Swift 3 objc
Browse files Browse the repository at this point in the history
…non-inference.

## Via updating `jdhealy/FABConfig`:

Clang: Warn about non-prototype declarations.
Clang: Warn about ranged-based for loops.
Clang: Warn about implicit conversions from Objective-C literals to values of incompatible type.
Clang: Warn about non-literal expressions that evaluate to zero being treated as a null pointer.
Clang: Warn about suspicious uses of the comma operator.
Clang: Warn about block captures of implicitly autoreleasing parameters.
  • Loading branch information
jdhealy committed Sep 28, 2017
1 parent 9e3cdf3 commit 3685a6b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Supporting Files/Configuration Support
1 change: 1 addition & 0 deletions Supporting Files/Configuration.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ INFOPLIST_FILE = Supporting Files/Info.plist

// As of Xcode 8S162m, the Swift Migrator doesn’t respect any `SWIFT_VERSION` from `xcconfig` files. So, until said improvement, manually duplicate the value below in ../PrettyColors.xcodeproj/project.pbxproj
// SWIFT_VERSION = "3.0"
SWIFT_SWIFT3_OBJC_INFERENCE = Off
SWIFT_OPTIMIZATION_LEVEL = -Owholemodule

COMBINE_HIDPI_IMAGES = YES
Expand Down
1 change: 1 addition & 0 deletions Tests/Supporting Files/Configuration.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

// As of Xcode 8S162m, the Swift Migrator doesn’t respect any `SWIFT_VERSION` from `xcconfig` files. So, until said improvement, manually duplicate the value below in ../../PrettyColors.xcodeproj/project.pbxproj
// SWIFT_VERSION = "3.0"
SWIFT_SWIFT3_OBJC_INFERENCE = Off
SWIFT_OPTIMIZATION_LEVEL = -Owholemodule

COMBINE_HIDPI_IMAGES = YES
Expand Down

0 comments on commit 3685a6b

Please sign in to comment.