-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Lazily require adapter mappings #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-babu
reviewed
Apr 21, 2023
jay-babu
reviewed
Apr 21, 2023
jay-babu
changed the title
perf: Fixed version of 'Lazily require adapter mappings'
perf: Lazily require adapter mappings
Apr 21, 2023
Thanks for all the help! merging attempt 2 |
jay-babu
added a commit
that referenced
this pull request
Apr 22, 2023
Co-authored-by: Jay Patel <36803168+jay-babu@users.noreply.github.com>
lua/mason-nvim-dap/mappings/adapters/init.lua
should be
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the performance improvement in #70 that should not cause #73 #74 which required the previous pull request #75 to need to be reversed.
Why?
The change in #70 returned errors whenever trying to get an adapter which was not mapped instead of just returning
nil
.What
The fix is simply to return
nil
for unmapped adapters. (Something which I thought of but then apparently did not do for some reason..)Testing Done (and which can be done)
I have tested with installing and running
java-debug-adapter
#73 which caused an error because it is not mapped inmason-nvim-dap.mappings.adapters
andelixir-ls
#74 which will try to get an adapter for'elixir'
when the handler is set up, which will is also not a mapping that exists.I am not regularly using these these adapters however so I would probably be good if someone who has encountered the problems in #73 and #74 tests this before any merging is done.