Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: #74: Revert adapter breaking changes #75

Merged

Conversation

antonpetrovmain
Copy link
Contributor

Why?

On a clean install the plugin cannot be configured due to issues with adapters, e.g. for javadbg:

Failed to run `config` for mason-nvim-dap.nvim

...m-dap.nvim/lua/mason-nvim-dap/mappings/adapters/init.lua:7: module 'mason-nvim-dap.mappings.adapters.javadbg' not found:
	no field package.preload['mason-nvim-dap.mappings.adapters.javadbg']

We would like to revert the last 2 commits that introduced the breaking change.

What?

Revert last 2 commits using git revert.

Testing done

  1. Updated to latest on the main branch.

  2. Verified that the error above exists.
    Screenshot 2023-04-20 at 17 07 30

  3. Reverted last 2 commits and observed there is no longer an issue with the javadbg adapter.
    Screenshot 2023-04-20 at 17 07 12

as expected.

Notes

Fixes #74.

@antonpetrovmain antonpetrovmain changed the title #74: Revert adapter breaking changes revert: #74: Revert adapter breaking changes Apr 20, 2023
@jay-babu jay-babu merged commit b874576 into jay-babu:main Apr 21, 2023
This was referenced Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elixir adapter not found
2 participants