Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bracket path support #334

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Allow bracket path support #334

merged 3 commits into from
Jan 17, 2018

Conversation

skvale
Copy link
Collaborator

@skvale skvale commented Jan 9, 2018

Fixes #307

@skvale skvale changed the title feat(Field): Allow bracket path support Allow bracket path support Jan 9, 2018
@jaredpalmer
Copy link
Owner

Nice I can review when I get back from CES in a few hours.

@jaredpalmer
Copy link
Owner

@skvale do you think fieldarray should be a separate package?

@skvale
Copy link
Collaborator Author

skvale commented Jan 10, 2018

I don't think I fully understand why fieldarray would or wouldn't be a separate package and how it relates.

@jaredpalmer jaredpalmer merged commit 560a5e3 into jaredpalmer:next Jan 17, 2018
@skvale skvale deleted the feature/307-bracket-support branch January 18, 2018 00:28
jaredpalmer added a commit that referenced this pull request Feb 1, 2018
* Close #200. Add Field level validation

* Regenerate doctoc

* Remove handleChangeValue completely

* v0.11.0-alpha.1

* Add missing name in call to setFieldError (#290)

* v0.11.0-alpha.2

* #281 Add array helpers MVP, update ts setup for better DX (#298)

* v0.11.0-alpha.3

* Actually export FieldArray

* v0.11.0-alpha.4

* Upgrade to React 16, TypeScript 2.6.2 (#300)

* #283 Update to React 16, TypeScript 2.6.2

* Update Travis build to use npm instead of yarn

* Move back to yarn (#301)

* Fix travis script to use yarn.

* Add form to TS types of FieldArray

* v0.11.0-beta.1

* Close #281 #155. Add docs about array helpers

* Add field array examples and update toc

* Fix unshift in FieldArray (#337)

* Fix FieldArray component prop (#341)

* Fix FieldArray component prop

* nit: test names [skip ci]

* Allow bracket path support (#334)

* feat(Field): Allow bracket path support

* chore(deps): Add types for lodash.topath

* chore(deps): yarn.lock

* Fix #280. Fix the definition dirty and isValid (#365)

* Fix #280. Change the meaning of dirty and isValid

* Lock in to path dep

* Update tests for new definition of dirty

* Update docs

* Fixed typo in FieldArray code (#380)

* Fix setDeep mutations with nested values (#373)

* Fix start task

* Get rid of mutators file

* v0.11.0-rc.1

* #285 #122 Add example multistep / form wizard

* #378 remove setFieldTouched from FieldArray

* v0.11.0-rc.2

* #223 Fix checkbox validation error (again)

* Add onReset callback. (#328)

* feat(formik): Add onReset callback.

* feat(formik): Use promise sniffing for onReset prop.

This passes returned promise data to resetForm, allowing the promise to add new nextValues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants