Add onReset callback. #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we reopen this against next branch? |
|
I just force pushed and changed the base |
|
Hey @skvale , |
|
I fixed the conflicts, but I am still waiting for a code review. |
|
Reviewing now |
jaredpalmer
reviewed
Jan 29, 2018
| @@ -423,6 +429,22 @@ export class Formik< | |||
| ); | |||
| }; | |||
|
|
|||
| getFormikActions = (): FormikActions<Values> => { | |||
There was a problem hiding this comment.
nice. this was long overdue.
src/formik.tsx
Outdated
| @@ -550,6 +560,9 @@ export class Formik< | |||
| }; | |||
|
|
|||
| handleReset = () => { | |||
| if (this.props.onReset) { | |||
| this.props.onReset(this.state.values, this.getFormikActions()); | |||
There was a problem hiding this comment.
Should we allow this to async?
Some ideas:
- sniff for a promise
- expose a done() argument
- force this to be sync
i think sniffing for a promise is the move.
naive implementation:
if (this.props.onReset) {
const maybePromise = this.props.onReset(this.state.values, this.getFormikActions());
if (isPromise(maybePromise)) {
// do we pass values returned by the promise?? hmmm.
maybePromise.then(this.resetForm)
} else {
this.resetForm();
}
}There was a problem hiding this comment.
if (this.props.onReset) {
const maybePromisedOnReset = (this.props.onReset as any)(
this.state.values,
this.getFormikActions()
);
if (isPromise(maybePromisedOnReset)) {
(maybePromisedOnReset as Promise<any>).then(this.resetForm);
} else {
this.resetForm();
}
}Maybe onReset returning new nextValues for resetForm will be useful ?
| expect(onReset).toHaveBeenCalledWith( | ||
| { foo: 'bar', bar: 'foo' }, | ||
| expect.objectContaining({ | ||
| resetForm: expect.any(Function), |
This passes returned promise data to resetForm, allowing the promise to add new nextValues.
jaredpalmer
added a commit
that referenced
this pull request
Feb 1, 2018
* Close #200. Add Field level validation * Regenerate doctoc * Remove handleChangeValue completely * v0.11.0-alpha.1 * Add missing name in call to setFieldError (#290) * v0.11.0-alpha.2 * #281 Add array helpers MVP, update ts setup for better DX (#298) * v0.11.0-alpha.3 * Actually export FieldArray * v0.11.0-alpha.4 * Upgrade to React 16, TypeScript 2.6.2 (#300) * #283 Update to React 16, TypeScript 2.6.2 * Update Travis build to use npm instead of yarn * Move back to yarn (#301) * Fix travis script to use yarn. * Add form to TS types of FieldArray * v0.11.0-beta.1 * Close #281 #155. Add docs about array helpers * Add field array examples and update toc * Fix unshift in FieldArray (#337) * Fix FieldArray component prop (#341) * Fix FieldArray component prop * nit: test names [skip ci] * Allow bracket path support (#334) * feat(Field): Allow bracket path support * chore(deps): Add types for lodash.topath * chore(deps): yarn.lock * Fix #280. Fix the definition dirty and isValid (#365) * Fix #280. Change the meaning of dirty and isValid * Lock in to path dep * Update tests for new definition of dirty * Update docs * Fixed typo in FieldArray code (#380) * Fix setDeep mutations with nested values (#373) * Fix start task * Get rid of mutators file * v0.11.0-rc.1 * #285 #122 Add example multistep / form wizard * #378 remove setFieldTouched from FieldArray * v0.11.0-rc.2 * #223 Fix checkbox validation error (again) * Add onReset callback. (#328) * feat(formik): Add onReset callback. * feat(formik): Use promise sniffing for onReset prop. This passes returned promise data to resetForm, allowing the promise to add new nextValues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since onSubmit had a callback, onReset seemed like it should have an equivalent one.
Fixes: #325