Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python version deprecations and add 3.8 testing #444

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Conversation

jantman
Copy link
Owner

@jantman jantman commented Oct 31, 2019

This PR fixes a number of issues related to python versions:

See the Changelog entry for details.

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #444 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #444   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           36     36           
  Lines         2677   2696   +19     
  Branches       410    410           
======================================
+ Hits          2677   2696   +19
Impacted Files Coverage Δ
awslimitchecker/checker.py 100% <100%> (ø) ⬆️
awslimitchecker/services/ec2.py 100% <0%> (ø) ⬆️
awslimitchecker/metrics/base.py 100% <0%> (ø) ⬆️
awslimitchecker/alerts/base.py 100% <0%> (ø) ⬆️
awslimitchecker/services/base.py 100% <0%> (ø) ⬆️
awslimitchecker/version.py 100% <0%> (ø) ⬆️
awslimitchecker/limit.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2737fad...04c1593. Read the comment docs.

@jantman jantman merged commit 5fa0804 into develop Oct 31, 2019
@jantman jantman deleted the issues/436 branch October 31, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants