Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow resize_to_fill to skip cropping #74 #75

Closed
wants to merge 1 commit into from

Conversation

etherbob
Copy link
Contributor

Adds the ability to pass crop: false to MiniMagick#resize_to_fill per #74

Unfortunately, I could not figure out a way to make this to work the same on the vips side.

@etherbob
Copy link
Contributor Author

Looks like libvips isn't available on the travis servers. Do I need to do something special to get the build working again?

@etherbob
Copy link
Contributor Author

etherbob commented Dec 8, 2020

@janko is there anything I can do to fix the build and get this back on track? My apologies if I'm missing something, I have not directly sent a PR before.

@janko
Copy link
Owner

janko commented Sep 26, 2021

Thanks for the pull request, and sorry for letting it fall off my radar. On master I've migrated from Travis CI to GitHub CI, so that should be passing once this branch is updated.

In general I agree the option of this kind of resizing should be there, and after some consideration I think I agree with overloading #resize_to_fill. We'll just need to do the same thing for the vips backend for consistency, and also update the documentation.

@brendon
Copy link
Contributor

brendon commented Apr 19, 2024

Just noticed that we both tacked the same problem. I managed to get it to work in both IM and VIPS but I created a seperate method cover: #75

@etherbob
Copy link
Contributor Author

closing in favor of #120 120

@etherbob etherbob closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants