Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to skip cropping on MiniMagick#resize_to_fill #74

Closed
etherbob opened this issue Nov 10, 2020 · 2 comments
Closed

Option to skip cropping on MiniMagick#resize_to_fill #74

etherbob opened this issue Nov 10, 2020 · 2 comments

Comments

@etherbob
Copy link
Contributor

Would you be amenable to a pull request that adds a crop: true parameter to MiniMagick#resize_to_fill that would then skip the cropping step when set to false?

We have a use case for calling resize("#{width}x#{height}^") and this seems like the logical place.
@janko
Copy link
Owner

janko commented Nov 11, 2020

Yes, that sounds reasonable 👍

etherbob pushed a commit to APMG/image_processing that referenced this issue Nov 20, 2020
allow resize_to_fill to skip cropping janko#74
35d3dc2
@etherbob etherbob mentioned this issue Nov 20, 2020
Closed
@janko
Copy link
Owner

janko commented Jun 6, 2024

Added in #120.

@janko janko closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janko @etherbob