Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined showing as false for radios #252

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

janechu
Copy link
Owner

@janechu janechu commented Mar 22, 2024

Pull Request

📖 Description

Radios will show false instead of no radio being selected when the value is undefined. This change fixes it so that they are not checked if the value is undefined.

🎫 Issues

Closes #229

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.

@janechu janechu self-assigned this Mar 22, 2024
Copy link

LCOV of commit c191569 during Validate Coverage #27

Summary coverage rate:
  lines......: 65.6% (1371 of 2091 lines)
  functions..: 74.7% (470 of 629 functions)
  branches...: 55.2% (548 of 993 branches)

Files changed coverage rate: n/a

design-to-code

@janechu janechu force-pushed the users/janechu/fix-undefined-showing-false-for-radios branch from 539da15 to 8db6845 Compare March 28, 2024 19:27
Copy link

LCOV of commit 8db6845 during Validate Coverage #35

Summary coverage rate:
  lines......: 65.6% (1371 of 2091 lines)
  functions..: 74.7% (470 of 629 functions)
  branches...: 55.2% (548 of 993 branches)

Files changed coverage rate: n/a

design-to-code

Copy link

LCOV of commit 8db6845 during Validate Coverage #35

Summary coverage rate:
  lines......: 50.7% (714 of 1408 lines)
  functions..: 52.0% (233 of 448 functions)
  branches...: 39.1% (343 of 877 branches)

Files changed coverage rate: n/a

design-to-code-react

@janechu janechu merged commit 1a184f5 into main Mar 28, 2024
2 of 3 checks passed
@janechu janechu deleted the users/janechu/fix-undefined-showing-false-for-radios branch March 28, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: A required boolean appears as "false"
1 participant