Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: A required boolean appears as "false" #229

Closed
janechu opened this issue Mar 8, 2024 · 0 comments · Fixed by #252
Closed

[Bug]: A required boolean appears as "false" #229

janechu opened this issue Mar 8, 2024 · 0 comments · Fixed by #252
Assignees
@janechu
Labels
bug Something isn't working

Comments

@janechu
Copy link
Owner

janechu commented Mar 8, 2024

What happened?

When a boolean property is required and undefined, it appears as false as a radio.

example:

{
    "type": "object",
    "properties": {
        "foo": {
            "type": "boolean"
        }
    },
    "required": ["foo"]
}

What package(s) are causing the problem?

design-to-code-react

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

No response
@janechu janechu added the bug Something isn't working label Mar 8, 2024
@janechu janechu self-assigned this Mar 8, 2024
@janechu janechu moved this to Todo in Design to Code Mar 8, 2024
@janechu janechu mentioned this issue Mar 22, 2024
Merged
3 tasks
janechu added a commit that referenced this issue Mar 28, 2024
@janechu
Fix undefined showing as false for radios (#252)
1a184f5 
# Pull Request

## 📖 Description

Radios will show `false` instead of no radio being selected when the value is undefined. This change fixes it so that they are not checked if the value is `undefined`.

### 🎫 Issues

Closes #229

## ✅ Checklist

### General

<!--- Review the list and put an x in the boxes that apply. -->

- [x] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
@github-project-automation github-project-automation bot moved this from Todo to Done in Design to Code Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janechu janechu

Labels
bug Something isn't working
Projects
Design to Code
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix undefined showing as false for radios janechu/design-to-code
1 participant
@janechu