Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health endpoint #808

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Add health endpoint #808

merged 3 commits into from
Sep 10, 2024

Conversation

paulgb
Copy link
Member

@paulgb paulgb commented Sep 10, 2024

We currently use /ctrl/status as a health check endpoint. The introduction of auth delegation (#804) applies, when enabled, to all /ctrl endpoints, including the health check. That means that the health checker needs to have credentials.

Instead, this adds a separate health check endpoint /pub/health which is part of the /pub path, which is not credentialed. This does not include the version information returned by the /ctrl/status endpoint, but does a health check.

@paulgb paulgb requested a review from rolyatmax September 10, 2024 13:54
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plane ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 2:16pm

Copy link
Member

@rolyatmax rolyatmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - failing test though

@paulgb paulgb merged commit b9c4d53 into main Sep 10, 2024
6 checks passed
@paulgb paulgb deleted the paulgb/add-health-endpoint branch September 10, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants