Allow Plane to delegate auth #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
michaelsilver
added a commit
that referenced
this pull request
Aug 30, 2024
Changes introduced in previous PR: #804
Merged
paulgb
added a commit
that referenced
this pull request
Sep 10, 2024
We currently use `/ctrl/status` as a health check endpoint. The introduction of auth delegation (#804) applies, when enabled, to all `/ctrl` endpoints, including the health check. That means that the health checker needs to have credentials. Instead, this adds a separate health check endpoint `/pub/health` which is part of the `/pub` path, which is not credentialed. This does not include the version information returned by the `/ctrl/status` endpoint, but does a health check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
forward_authconfig option (name borrowed from Caddy). If provided, requests to/ctrl/*are forwarded to that URL first (after stripping the body). If that URL returns a 200, Plane proceeds; otherwise they are rejected.