Issue 356 maximum lookback should be retention period #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
=========================================
+ Coverage 88.95% 89.06% +0.1%
=========================================
Files 162 162
Lines 3640 3658 +18
Branches 829 831 +2
=========================================
+ Hits 3238 3258 +20
+ Misses 366 364 -2
Partials 36 36
Continue to review full report at Codecov.
|
everett980
commented
May 21, 2019
|
Use "resolves" or "closes" or "fixes", otherwise it's not being recognized by GitHub automatically. |
That explains why my previous PRs merely "mentioned" issues without closing them and I had to do it manually. Thanks! |
Signed-off-by: Everett Ross <reverett@uber.com>
tiffon
suggested changes
May 22, 2019
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js
Outdated
Show resolved
Hide resolved
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.test.js
Outdated
Show resolved
Hide resolved
everett980
commented
May 23, 2019
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js
Outdated
Show resolved
Hide resolved
label for equivalent options Signed-off-by: Everett Ross <reverett@uber.com>
state through mapStateToProps, Clean up global getJaegerUiConfig warning suppression Signed-off-by: Everett Ross <reverett@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
get-config.tsx