Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The maximum search lookback should be the trace retention period #356

Closed
tiffon opened this issue Mar 21, 2019 · 3 comments · Fixed by #384
Closed

The maximum search lookback should be the trace retention period #356

tiffon opened this issue Mar 21, 2019 · 3 comments · Fixed by #384
Assignees
Labels

Comments

@tiffon
Copy link
Member

tiffon commented Mar 21, 2019

The lookback option in the search form, on the search page, should have the full retention period of traces as the max option. Currently, it is hardcoded to two days, but the retention period is configurable.

@vprithvi, @jaegertracing/elasticsearch is it possible for the query service to know this retention so it can be passed into the UI, dynamically? The alternative is to make a field in the UI config, but it would then need to be maintained as part of a deployment rather than adjusting, automatically.

@tiffon tiffon added the bug label Mar 21, 2019
@yurishkuro
Copy link
Member

Retention period is usually configured in the storage, query-service often doesn't know about it. I would make it a param in the UI config.

@everett980
Copy link
Collaborator

How does search interact with archived traces? Are archived traces only accessible via /trace/${archivedID} or can they show up in search results as well?

@yurishkuro
Copy link
Member

@everett980 the handler for /trace/${archivedID} automatically falls back to archive storage if it doesn't find the trace in the main storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants