Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix typo in configuration and add convenience setter for metricRegistry #71

Merged
merged 2 commits into from
Oct 5, 2016
+13 −0
Merged

Fix typo in configuration and add convenience setter for metricRegistry #71

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b72ee31
Fix typo in configuration and add convenience setter for metricRegistry
vprithvi Oct 5, 2016
a66b757
Add javadoc
vprithvi Oct 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jaeger-core/src/main/java/com/uber/jaeger/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,15 @@ synchronized public io.opentracing.Tracer getTracer() {
return tracer;
}

@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment explaining what should be used instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

public void setStatsFactor(StatsFactory statsFactory) {
this.statsFactory = statsFactory;
}

public void setStatsFactory(StatsFactory statsFactory) {
this.statsFactory = statsFactory;
}

/**
* SamplerConfiguration allows to configure which sampler the tracer will use.
*/
Expand Down
5 changes: 5 additions & 0 deletions jaeger-dropwizard/src/main/java/com/uber/jaeger/dropwizard/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*/
package com.uber.jaeger.dropwizard;

import com.codahale.metrics.MetricRegistry;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand Down Expand Up @@ -51,4 +52,8 @@ synchronized public Tracer getTracer() {
}
return super.getTracer();
}

public void setMetricRegistry(MetricRegistry metricRegistry) {
setStatsFactory(new StatsFactory(metricRegistry));
}
}