Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Fix typo in configuration and add convenience setter for metricRegistry #71

Merged
merged 2 commits into from
Oct 5, 2016
Merged

Fix typo in configuration and add convenience setter for metricRegistry #71

merged 2 commits into from
Oct 5, 2016

Conversation

vprithvi
Copy link
Contributor

@vprithvi vprithvi commented Oct 5, 2016

  • dropwizard configuration users can easily set a dropwizard metricRegistry

@vprithvi
Fix typo in configuration and add convenience setter for metricRegistry
b72ee31 
- dropwizard configuration users can easily set a dropwizard metricRegistry
yurishkuro
yurishkuro reviewed Oct 5, 2016
View reviewed changes
jaeger-core/src/main/java/com/uber/jaeger/Configuration.java
@@ -98,10 +98,15 @@ public Configuration(
return tracer;
}

@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment explaining what should be used instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vprithvi vprithvi merged commit 9139806 into master Oct 5, 2016
@vprithvi vprithvi deleted the fix_typo branch October 5, 2016 18:53
@pavolloffay pavolloffay mentioned this pull request May 10, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vprithvi @yurishkuro