Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add specification version to jars, and impl-title/version & spec vers… #533

Merged
merged 3 commits into from
Aug 23, 2018

Conversation

objectiser
Copy link
Contributor

…ion to javadoc and sources jars

Signed-off-by: Gary Brown gary@brownuk.com

Which problem is this PR solving?

Adding missing manifest information to the jars (main, javadoc and source).

Short description of the changes

Make sure Implementation-Title, Implementation-Version and Specification-Version are applied to all three jars for each module.

@ghost ghost assigned objectiser Aug 23, 2018
@ghost ghost added the review label Aug 23, 2018
…ion to javadoc and sources jars

Signed-off-by: Gary Brown <gary@brownuk.com>
Copy link
Collaborator

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

If you want to get it even better, it's probably possible to have one manifest for all three JAR tasks.

@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #533 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #533   +/-   ##
=========================================
  Coverage     88.42%   88.42%           
  Complexity      505      505           
=========================================
  Files            66       66           
  Lines          1883     1883           
  Branches        239      239           
=========================================
  Hits           1665     1665           
  Misses          142      142           
  Partials         76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2ddfc...e610f08. Read the comment docs.

Signed-off-by: Gary Brown <gary@brownuk.com>
Signed-off-by: Gary Brown <gary@brownuk.com>
@jpkrohling jpkrohling merged commit 8b35787 into jaegertracing:master Aug 23, 2018
@ghost ghost removed the review label Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants