Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Commit

Permalink
Add specification version to jars, and impl-title/version & spec vers… (
Browse files Browse the repository at this point in the history
#533)

* Add specification version to jars, and impl-title/version & spec version to javadoc and sources jars

Signed-off-by: Gary Brown <gary@brownuk.com>

* Refactored to have shared manifest in publish.gradle

Signed-off-by: Gary Brown <gary@brownuk.com>

* New improved approach thanks to @jpkrohling

Signed-off-by: Gary Brown <gary@brownuk.com>
  • Loading branch information
objectiser authored and jpkrohling committed Aug 23, 2018
1 parent 3c2ddfc commit 8b35787
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ subprojects {

jar {
from sourceSets.main.output
manifest {
attributes('Implementation-Title': project.name, 'Implementation-Version': project.version)
}
}

if (!version.endsWith("SNAPSHOT")) {
Expand Down Expand Up @@ -192,6 +189,11 @@ configure(subprojects.findAll {it.name != 'jaeger-thrift'}) {
// These are disabled because of a bug with errorprone. See https://github.com/google/error-prone/issues/750
options.compilerArgs += [ '-Xep:NestedInstanceOfConditions:OFF', '-Xep:InstanceOfAndCastMatchWrongType:OFF' ]
}
tasks.withType(Jar) {
manifest {
attributes('Implementation-Title': project.name, 'Implementation-Version': project.version, 'Specification-Version': project.version)
}
}
}

def getVersionForBuild() {
Expand Down

0 comments on commit 8b35787

Please sign in to comment.