Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Updating the ReporterConfig to set Sender Correctly #370

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Updating the ReporterConfig to set Sender Correctly #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jaeger-core/src/main/java/com/uber/jaeger/Configuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ public ReporterConfiguration withSender(SenderConfiguration senderConfiguration)
private Reporter getReporter(Metrics metrics) {
Reporter reporter = new RemoteReporter.Builder()
.withMetrics(metrics)
.withSender(senderConfiguration.sender)
.withSender(senderConfiguration.getSender())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, come on, Java, it's a private field, why is it visible to a class defined at the same level?

.withFlushInterval(numberOrDefault(this.flushIntervalMs, RemoteReporter.DEFAULT_FLUSH_INTERVAL_MS).intValue())
.withMaxQueueSize(numberOrDefault(this.maxQueueSize, RemoteReporter.DEFAULT_MAX_QUEUE_SIZE).intValue())
.build();
Expand Down