This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Updating the ReporterConfig to set Sender Correctly #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small bug in the private getReporter(..) method was resulting in the sender always being set to the default UdpSender. This is because the field `senderConfiguration.sender` is null until the `getSender()` method is called on it. Because the reporter builder was accessing the field directly rather than through the getter, it was always UdpSen a null sender, thus defaulting to the UdpSender even if the JAEGER_ENDPOINT property was set. This commit fixes the problem, accessing the configured sender through the appropriate getter, allowing the user configurations to propagate through to the tracer retrieved via the `Configuration.fromEnv().getTracer()` method. Signed-off-by: Nate Hart <nhart@tableau.com>
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
===========================================
+ Coverage 84.46% 84.5% +0.04%
Complexity 619 619
===========================================
Files 95 95
Lines 2459 2459
Branches 274 274
===========================================
+ Hits 2077 2078 +1
+ Misses 285 284 -1
Partials 97 97
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Mar 15, 2018
| @@ -570,7 +570,7 @@ public ReporterConfiguration withSender(SenderConfiguration senderConfiguration) | |||
| private Reporter getReporter(Metrics metrics) { | |||
| Reporter reporter = new RemoteReporter.Builder() | |||
| .withMetrics(metrics) | |||
| .withSender(senderConfiguration.sender) | |||
| .withSender(senderConfiguration.getSender()) | |||
There was a problem hiding this comment.
oh, come on, Java, it's a private field, why is it visible to a class defined at the same level?
|
thanks @natehart cc @pavolloffay |
jpkrohling
approved these changes
Mar 16, 2018
pavolloffay
approved these changes
Mar 16, 2018
|
@jpkrohling could you please cut a micro release with this change? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small bug in the private getReporter(..) method was resulting in the sender
always being set to the default UdpSender. This is because the field
senderConfiguration.senderis null until thegetSender()method is called onit. Because the reporter builder was accessing the field directly rather than
through the getter, it was always UdpSen a null sender, thus defaulting to the
UdpSender even if the JAEGER_ENDPOINT property was set.
This commit fixes the problem, accessing the configured sender through the
appropriate getter, allowing the user configurations to propagate through to the
tracer retrieved via the
Configuration.fromEnv().getTracer()method.Signed-off-by: Nate Hart nhart@tableau.com