Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Combine constants and reuse port #415

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

yurishkuro
Copy link
Member

To avoid duplicating the port number

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #415 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   88.47%   88.44%   -0.04%     
==========================================
  Files          55       55              
  Lines        3107     3107              
==========================================
- Hits         2749     2748       -1     
- Misses        253      255       +2     
+ Partials      105      104       -1
Impacted Files Coverage Δ
sampler.go 94.75% <100%> (ø) ⬆️
internal/baggage/remote/restriction_manager.go 95.77% <0%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7148435...a7db318. Read the comment docs.

@yurishkuro yurishkuro merged commit e8ef996 into jaegertracing:master Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant