This repository has been archived by the owner on May 23, 2024. It is now read-only.
Default sampling server URL to agent #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If JAEGER_AGENT_HOST is set but JAEGER_SAMPLER_MANAGER_HOST_PORT is not, default the sampler manager to point at the agent. This simplifies configuration in containerised environments. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 88.43% 88.44% +<.01%
==========================================
Files 55 55
Lines 3105 3107 +2
==========================================
+ Hits 2746 2748 +2
Misses 255 255
Partials 104 104
Continue to review full report at Codecov.
|
|
small clean-up #415 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #388
Short description of the changes
If
JAEGER_AGENT_HOSTis set butJAEGER_SAMPLER_MANAGER_HOST_PORTis not, default the sampler manager to point at the agent.