feat(ser): Trait Abstractions #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Aug 25, 2024
crates/ser/src/types/sync.rs
Outdated
| /// | ||
| /// [ss]: https://github.com/ethereum-optimism/optimism/blob/develop/op-service/eth/sync_status.go#L5 | ||
| #[derive(Clone, Debug, PartialEq, Eq, serde::Serialize, serde::Deserialize)] | ||
| pub struct SyncStatus { |
There was a problem hiding this comment.
before we introduce these here,
could we instead move all of these
to op-alloy instead and import?
but could also do this in a followup
There was a problem hiding this comment.
Looks like someone saw this and already put up a pr :) alloy-rs/op-alloy#35
There was a problem hiding this comment.
Happy to wait until that's in and re-use those types.
crates/ser/src/types/transaction.rs
Outdated
Comment on lines
30
to
36
| fn from(tx: &BatchTransaction) -> Self { | ||
| let mut buf: Vec<u8> = Vec::new(); | ||
| for frame in tx.frames.iter() { | ||
| buf.append(&mut frame.encode()); | ||
| } | ||
| buf.into() | ||
| } |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning
Follows #22 - don't merge until #22 is in trunk
Adds trait abstractions and associated types to the
sercrate.Metadata
Closes #20