Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move optimism rpc types to op-alloy #10509

Closed
Tracked by #12576
mattsse opened this issue Aug 25, 2024 · 2 comments
Closed
Tracked by #12576

Move optimism rpc types to op-alloy #10509

mattsse opened this issue Aug 25, 2024 · 2 comments
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 25, 2024

Describe the feature

we have a few optimism rpc types:

pub struct L2BlockRef {

that should be moved to https://github.com/alloy-rs/op-alloy/tree/main/crates/rpc-types

TODO

  • move op rpc types to op-alloy

Additional context

ref ithacaxyz/op-rs#25

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 25, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Aug 25, 2024
@Redidacove
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a student and into Ethereum for a while now participating in Ethereum as a permissionless fellow for implementation of EIP 7732 with potuz and terence as mentors and working on Prysm so can understand the issue well enough.

How I plan on tackling this issue

It's simple refactoring problem just needs to open a pr in op-alloy after adding types in it and then another pr in reth after the first gets merged importing the given types.

@Redidacove
Copy link
Contributor

@mattsse This will be closed by my pr which is currently blocked until next op-alloy release as mentioned by @emhane

@mattsse mattsse closed this as completed Aug 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants