Istio Envoy fork tsan test failure

[bianpengyuan]

Istio envoy 1.7 branch tsan test always fails. Here is an example failed run: https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_envoy/293/test-tsan_envoy_release-1.7/1354917515653812224

To temporarily work around that, we will make tsan test option there, and use this issue to track fixing and enabling it again.

[bianpengyuan]

Same happens to 1.8

[bianpengyuan]

looks like the failure is from envoy-filter-example build. somehow bazel 4.0.0 is used, which is released 1/21 and way ahead of 3.1.0 that envoy 1.15 / istio 1.7 is using, and a deprecated bazel rule param causes the failure:

Building and testing envoy-filter-example tests...
/build/envoy-filter-example /home/prow/go/src/istio.io/envoy
2021/01/29 02:21:11 Downloading https://releases.bazel.build/4.0.0/release/bazel-4.0.0-linux-x86_64...
$TEST_TMPDIR defined: output root default is '/build/tmp' and max_idle_secs default is '15'.
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
WARNING: option '--build_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
WARNING: option '--test_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:68:14: 
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:14: rbe_ubuntu_clang not using checked in configs; Bazel version 4.0.0 was picked/selected but no checked in config was found in map {"3.3.1": ["clang", "clang_libcxx", "gcc"], "3.4.1": ["clang", "clang_libcxx", "gcc"]}
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:68:14: 
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:14: rbe_ubuntu_clang_libcxx not using checked in configs; Bazel version 4.0.0 was picked/selected but no checked in config was found in map {"3.3.1": ["clang", "clang_libcxx", "gcc"], "3.4.1": ["clang", "clang_libcxx", "gcc"]}
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:68:14: 
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:14: rbe_ubuntu_gcc not using checked in configs; Bazel version 4.0.0 was picked/selected but no checked in config was found in map {"3.3.1": ["clang", "clang_libcxx", "gcc"], "3.4.1": ["clang", "clang_libcxx", "gcc"]}
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:68:14: 
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:14: rbe_windows_msvc_cl not using checked in configs; Bazel version 4.0.0 was picked/selected but no checked in config was found in map {"3.3.1": ["msvc-cl", "clang-cl"], "3.4.1": ["msvc-cl", "clang-cl"]}
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:68:14: 
Current running Bazel is ahead of bazel-toolchains repo. Please update your pin to bazel-toolchains repo in your WORKSPACE file.
DEBUG: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/bazel_toolchains/rules/rbe_repo/checked_in.bzl:125:14: rbe_windows_clang_cl not using checked in configs; Bazel version 4.0.0 was picked/selected but no checked in config was found in map {"3.3.1": ["msvc-cl", "clang-cl"], "3.4.1": ["msvc-cl", "clang-cl"]}
Loading: 0 packages loaded
    currently loading:  ... (2 packages)
Analyzing: 3 targets (2 packages loaded)
Analyzing: 3 targets (2 packages loaded, 0 targets configured)
Analyzing: 3 targets (22 packages loaded, 30 targets configured)
Analyzing: 3 targets (22 packages loaded, 30 targets configured)
Analyzing: 3 targets (37 packages loaded, 360 targets configured)
ERROR: /build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/envoy/bazel/foreign_cc/BUILD:82:21: in cmake_external rule @envoy//bazel/foreign_cc:ares: 
Traceback (most recent call last):
	File "/build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/rules_foreign_cc/tools/build_defs/cmake.bzl", line 46, column 33, in _cmake_external
		return cc_external_rule_impl(ctx, attrs)
	File "/build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/rules_foreign_cc/tools/build_defs/framework.bzl", line 209, column 38, in cc_external_rule_impl
		out_cc_info = _define_out_cc_info(ctx, attrs, inputs, outputs)
	File "/build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/rules_foreign_cc/tools/build_defs/framework.bzl", line 650, column 39, in _define_out_cc_info
		linking_info = create_linking_info(ctx, attrs.linkopts, outputs.libraries)
	File "/build/tmp/_bazel_root/400406edc57d332f0b9b805d2b8e33a1/external/rules_foreign_cc/tools/build_defs/cc_toolchain_util.bzl", line 216, column 44, in create_linking_info
		return cc_common.create_linking_context(
Error in create_linking_context: in call to create_linking_context(), parameter 'user_link_flags' is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_require_linker_input_cc_api=false