Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge envoy/release/v1.16 into release-1.8 #294

Merged
merged 8 commits into from
Feb 5, 2021
Merged

Merge envoy/release/v1.16 into release-1.8 #294

merged 8 commits into from
Feb 5, 2021

Conversation

tbarrella
Copy link

This is expected to include a fix for istio/istio#28620

Shikugawa and others added 8 commits December 3, 2020 09:45
Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1

Risk Level: low
Testing: new unit, integration tests
Docs Changes: n/a
Release Notes: inline
Signed-off-by: Shikugawa <rei@tetrate.io>
Co-authored-by: alyssawilk <alyssar@chromium.org>
…roxy#14066) (envoyproxy#14279)

Commit Message: Allow supervisord to open its log file
Additional Description:
Change the default location of the log file and give supervisord
permissions to write to it.

Risk Level: low
Testing: built image locally
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
… is marked dead by Lua GC (envoyproxy#14092) (envoyproxy#14449)

Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>
… event. (envoyproxy#13858) (envoyproxy#14452)

Fixes envoyproxy#13856.

This change also contains the following backports:
- build: Fix some unused variable warnings (envoyproxy#13987)
- test: Check in all TLS test certs (envoyproxy#13702)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
…4456)

Additional Description: Based on envoyproxy#14388
Risk Level: Low
Testing: Build and run the repro from envoyproxy#14119 without crashing, `bazel test test/extensions/clusters/aggregate:cluster_test`
Docs Changes: N/A
Release Notes:
envoyproxy#14119

Signed-off-by: Taylor Barrella <tabarr@google.com>
Signed-off-by: Taylor Barrella <tabarr@google.com>
@google-cla
Copy link

google-cla bot commented Jan 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@bianpengyuan
Copy link

Sigh.. looks like the same issue happens in 1.8.. istio/istio#30484

@bianpengyuan
Copy link

istio/test-infra#3161

@bianpengyuan
Copy link

/retest

2 similar comments
@bianpengyuan
Copy link

/retest

@bianpengyuan
Copy link

/retest

@bianpengyuan
Copy link

/retest

1 similar comment
@tbarrella
Copy link
Author

/retest

@bianpengyuan
Copy link

the failure is from envoy-filter-example build. somehow bazel 4.0.0, which is ahead 3.4.1 that istio 1.8 is using, and a deprecated bazel rule param causes the failure. In upstream envoy CI, there is a sync flow to handle envoy-filter-example repo git submodule sync. However the sync is very envoy ci specific, so hard to use and maintain at Istio CI. I tried to turn off the example build, but cannot find a working env variable.. I think we can just comment out these two blocks in ci script:

envoy/ci/do_ci.sh

Lines 218 to 223 in 81b7bb3

if [ "${ENVOY_BUILD_FILTER_EXAMPLE}" == "1" ]; then
echo "Building and testing envoy-filter-example tests..."
pushd "${ENVOY_FILTER_EXAMPLE_SRCDIR}"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" "${ENVOY_FILTER_EXAMPLE_TESTS[@]}"
popd
fi
and

envoy/ci/do_ci.sh

Lines 242 to 247 in 81b7bb3

if [ "${ENVOY_BUILD_FILTER_EXAMPLE}" == "1" ]; then
echo "Building and testing envoy-filter-example tests..."
pushd "${ENVOY_FILTER_EXAMPLE_SRCDIR}"
bazel_with_collection test "${BAZEL_BUILD_OPTIONS[@]}" -c dbg --config=clang-tsan "${ENVOY_FILTER_EXAMPLE_TESTS[@]}"
popd
fi

@bianpengyuan
Copy link

/retest

@istio-testing istio-testing merged commit 5b0c5f7 into istio:release-1.8 Feb 5, 2021
@tbarrella tbarrella deleted the istio-1.8 branch February 5, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants