Skip to content

Commit

Permalink
api_proto_plugin: create visitor per file (envoyproxy#9267)
Browse files Browse the repository at this point in the history
Create visitor.Visitor per proto file to get correct information from TypeWhisperer.
This will make it easier to track imports in protoxform as well.

Risk Level: Low
Testing: CI

Fixes envoyproxy#9266

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
  • Loading branch information
lizan authored and htuch committed Dec 9, 2019
1 parent dfe687d commit 80cea11
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/api_proto_plugin/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
# Output files are generated alongside their corresponding input .proto,
# with the output_suffix appended.
'output_suffix',
# The visitor is a function to create a visitor.Visitor defining the business
# logic of the plugin for the specific output descriptor.
# The visitor factory is a function to create a visitor.Visitor defining
# the business logic of the plugin for the specific output descriptor.
'visitor_factory',
# FileDescriptorProto transformer; this is applied to the input
# before any output generation.
Expand Down

0 comments on commit 80cea11

Please sign in to comment.