TypeWhisperer generates incorrect proto path and type_db_gen depends on order

[lizan]

For example, bazel-bin/external/envoy_api/envoy/admin/v2alpha/pkg/envoy/admin/v2alpha/tap.proto.types.pb_text contains much more than what in envoy/admin/v2alpha/tap.proto:

types {
  key: "envoy.admin.v2alpha.BootstrapConfigDump"
  value {
    qualified_package: "envoy.admin.v2alpha"
    proto_path: "envoy/admin/v2alpha/tap.proto"
    type_dependencies: "google.protobuf.Timestamp"
    type_dependencies: "envoy.config.bootstrap.v2.Bootstrap"
  }
}
types {
  key: "envoy.admin.v2alpha.Certificate"
  value {
    qualified_package: "envoy.admin.v2alpha"
    proto_path: "envoy/admin/v2alpha/tap.proto"
    type_dependencies: "envoy.admin.v2alpha.CertificateDetails"
  }
}
types {
  key: "envoy.admin.v2alpha.CertificateDetails"
  value {
    qualified_package: "envoy.admin.v2alpha"
    proto_path: "envoy/admin/v2alpha/tap.proto"
    type_dependencies: "google.protobuf.Timestamp"
    type_dependencies: "envoy.admin.v2alpha.SubjectAlternateName"
  }
}
types {
  key: "envoy.admin.v2alpha.Certificates"
  value {
    qualified_package: "envoy.admin.v2alpha"
...

which should only include:

types {
  key: "envoy.admin.v2alpha.TapRequest"
  value {
    qualified_package: "envoy.admin.v2alpha"
    proto_path: "envoy/admin/v2alpha/tap.proto"
    type_dependencies: "envoy.service.tap.v2alpha.TapConfig"
  }
}

This seems because api_proto_plugin's visitor.Visitor should be stateless while TypeWhisperer is stateful and keeps types in self._types.

@htuch

[htuch]

This is definitely a bug, will have to look into this more tomorrow, but the root cause is the weirdness around how aspects traverse dependencies I think; we end up with each file being visited multiple times.

[lizan]

@htuch #9267 to fix this.