Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes rigid object's root com velocities timestamp check #1674

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ori-gadot
Copy link

Description

The rigid body data properties root_com_vel_w, root_com_pos_w, and root_com_ang_vel_w currently check the private state field's timestamp before updating their state. However, the issue lies in the fact that these COM state properties are incorrectly checking the link state field's timestamp instead of the COM's own state.

Fixes # (issue)
Replacing root link state with root com state at these properties.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants