impl of withdrawroute #25
Conversation
| return fmt.Errorf("cannot remove route from the local announcement route table: %v", err) | ||
| } | ||
|
|
||
| if remaining == 0 { |
There was a problem hiding this comment.
I think this is wrong.
When we remove a nexthop this info should also be distributed to the peers, even if there are some remaining nexthops for this route.
There was a problem hiding this comment.
It is just written (actually the same way) as removeReceivedRoute(), which keeps the consistent behaviour as the metalbond server would do when it learns that a route (with a next hop) needs to be deleted.
The next hop things could be taken care of in a more thorough way in the near future, I think.
There was a problem hiding this comment.
No. removeReceivedRoute() removes the nexthop. And then if the route has 0 nexthops, it removes the complete route from the table.
Here we want to de-announce a prior nexthop announcement. So the remaining == 0 check is wrong.
There was a problem hiding this comment.
as discussed in our Call, please add a // TODO: check logic remark above the if statement.
| } | ||
|
|
||
| if remaining == 0 { | ||
| if err := m.distributeRouteToPeers(REMOVE, vni, dest, hop, nil); err != nil { |
There was a problem hiding this comment.
AnnounceRoute() calls distributeRouteToPeers() after a m.peerMtx.RLock() lock on the peer Mutex.
This should also be done here, I think.
|
This PR still has an open issue, that is referred and discussed in https://github.com/onmetal/metalbond/issues/23 |
Proposed Changes
This PR provides am implementation of withdrawing a single route from metalbond.