Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VectorDistribution] Fix 0-rank vector.broadcast distribution #19007

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

Groverkss
Copy link
Contributor

@Groverkss Groverkss commented Nov 4, 2024

Fixes: #18955

Also removes locally carried revert

@Groverkss Groverkss changed the title [VectorDistribution] Do not treat 0-rank vectors as special [VectorDistribution] Fix 0-rank vector.broadcast distribution Nov 4, 2024
@Groverkss Groverkss force-pushed the remove-revert-0-rank-vector branch 2 times, most recently from 7b0fccf to 1deb5a1 Compare November 8, 2024 14:35
Copy link
Contributor

@qedawkins qedawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests for rank 0 vectors/broadcast

@Groverkss Groverkss force-pushed the remove-revert-0-rank-vector branch from 1deb5a1 to 6bef0ea Compare November 11, 2024 20:58
@Groverkss
Copy link
Contributor Author

Do we have any tests for rank 0 vectors/broadcast

added test

@Groverkss Groverkss requested a review from qedawkins November 11, 2024 20:58
@Groverkss Groverkss enabled auto-merge (squash) November 11, 2024 21:11
@Groverkss Groverkss merged commit 7f7cfb0 into iree-org:main Nov 11, 2024
36 checks passed
aviator19941 added a commit to aviator19941/iree that referenced this pull request Nov 13, 2024
aviator19941 added a commit to aviator19941/iree that referenced this pull request Nov 13, 2024
…iree-org#19007)"

This reverts commit 7f7cfb0.

Signed-off-by: aviator19941 <avinash.sharma@amd.com>
banach-space added a commit to banach-space/iree that referenced this pull request Nov 14, 2024
See iree-org#19135 for a discussion.

Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
banach-space added a commit to banach-space/iree that referenced this pull request Nov 14, 2024
See iree-org#19135 for a discussion.

Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
banach-space added a commit that referenced this pull request Nov 15, 2024
See #19135 for a discussion.

Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
Groverkss added a commit to Groverkss/iree that referenced this pull request Dec 1, 2024
Groverkss pushed a commit to Groverkss/iree that referenced this pull request Dec 1, 2024
See iree-org#19135 for a discussion.

Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
giacs-epic pushed a commit to giacs-epic/iree that referenced this pull request Dec 4, 2024
…rg#19007)

Fixes: iree-org#18955

Also removes locally carried revert

Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
giacs-epic pushed a commit to giacs-epic/iree that referenced this pull request Dec 4, 2024
See iree-org#19135 for a discussion.

Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VectorDistribute] Zero dimensional vectors causing distribution failure in VectorDistribute
2 participants