-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VectorDistribution] Fix 0-rank vector.broadcast distribution #19007
Merged
Groverkss
merged 3 commits into
iree-org:main
from
Groverkss:remove-revert-0-rank-vector
Nov 11, 2024
Merged
[VectorDistribution] Fix 0-rank vector.broadcast distribution #19007
Groverkss
merged 3 commits into
iree-org:main
from
Groverkss:remove-revert-0-rank-vector
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
requested review from
antiagainst,
qedawkins and
MaheshRavishankar
as code owners
November 4, 2024 15:07
Groverkss
changed the title
[VectorDistribution] Do not treat 0-rank vectors as special
[VectorDistribution] Fix 0-rank vector.broadcast distribution
Nov 4, 2024
Groverkss
force-pushed
the
remove-revert-0-rank-vector
branch
2 times, most recently
from
November 8, 2024 14:35
7b0fccf
to
1deb5a1
Compare
qedawkins
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any tests for rank 0 vectors/broadcast
Groverkss
force-pushed
the
remove-revert-0-rank-vector
branch
from
November 11, 2024 20:58
1deb5a1
to
6bef0ea
Compare
added test |
qedawkins
approved these changes
Nov 11, 2024
aviator19941
added a commit
to aviator19941/iree
that referenced
this pull request
Nov 13, 2024
…iree-org#19007)" This reverts commit 7f7cfb0.
aviator19941
added a commit
to aviator19941/iree
that referenced
this pull request
Nov 13, 2024
…iree-org#19007)" This reverts commit 7f7cfb0. Signed-off-by: aviator19941 <avinash.sharma@amd.com>
banach-space
added a commit
to banach-space/iree
that referenced
this pull request
Nov 14, 2024
See iree-org#19135 for a discussion. Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
banach-space
added a commit
to banach-space/iree
that referenced
this pull request
Nov 14, 2024
See iree-org#19135 for a discussion. Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
banach-space
added a commit
that referenced
this pull request
Nov 15, 2024
Groverkss
added a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
…rg#19007) Fixes: iree-org#18955 Also removes locally carried revert
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
See iree-org#19135 for a discussion. Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
…rg#19007) Fixes: iree-org#18955 Also removes locally carried revert Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
See iree-org#19135 for a discussion. Signed-off-by: Andrzej Warzynski <andrzej.warzynski@arm.com> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18955
Also removes locally carried revert