[VectorDistribute] Zero dimensional vectors causing distribution failure in VectorDistribute #18955
Assignees
Comments
Max191
added a commit
that referenced
this issue
Oct 31, 2024
) - bump llvm-project to llvm/llvm-project@f1595ec - revert iree-org/llvm-project@1004865 due to compiler failures in VectorDistribute. Tracked in #18955. - bump stablehlo to openxla/stablehlo@c32f7c2 - bump torch-mlir to llvm/torch-mlir@8b0bf2e - revert llvm/torch-mlir@55ff110 due to new onnx failures. Tracked in #18961 --------- Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Groverkss
added a commit
that referenced
this issue
Nov 11, 2024
Fixes: #18955 Also removes locally carried revert
Groverkss
added a commit
to Groverkss/iree
that referenced
this issue
Dec 1, 2024
…rg#19007) Fixes: iree-org#18955 Also removes locally carried revert
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this issue
Dec 4, 2024
…e-org#18897) - bump llvm-project to llvm/llvm-project@f1595ec - revert iree-org/llvm-project@1004865 due to compiler failures in VectorDistribute. Tracked in iree-org#18955. - bump stablehlo to openxla/stablehlo@c32f7c2 - bump torch-mlir to llvm/torch-mlir@8b0bf2e - revert llvm/torch-mlir@55ff110 due to new onnx failures. Tracked in iree-org#18961 --------- Signed-off-by: Max Dawkins <max.dawkins@gmail.com> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this issue
Dec 4, 2024
…rg#19007) Fixes: iree-org#18955 Also removes locally carried revert Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A new change in mlir (llvm/llvm-project@1004865#diff-51a55079ee1ee8936812c5be30869c89451372a0c675ff80ff739998c494e806L750) introduces zero dimensional vector transfers, which causes VectorDistribute to break later on. The change is reverted for now, but we need to fix the bug to reapply the patch.
Repro
The following gist contains an executable benchmark and a compile command for reproducing the failure:
https://gist.github.com/Max191/8a110c7eb192377c5f0665a14382f2b6
iree-compile test.mlir --compile-from=executable-sources --iree-hal-target-backends=rocm --iree-hip-target=gfx942 --iree-input-demote-f64-to-f32 -o /tmp/z.vmfbPass Repro
The gist also includes a smaller pass reproducer of just the VectorDistribute pass that fails:
iree-opt --pass-pipeline="builtin.module(func.func(iree-llvmgpu-vector-distribute))" pass_repro.mlirThe text was updated successfully, but these errors were encountered: