Cleanup unused Dockerfiles and build_all.yml workflow. #18222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuennancy
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #18144. Related to #15332.
build_all.ymlwas used as the first step in multiple other workflows. New workflows are usingpkgci_build_packages.ymldirectly or nightly releases. Workflows could also use historical artifacts frompkgci_build_packages.ymlif they want to use versions different from the nightly releases.android.Dockerfilewas used for Android builds and benchmarks. New workflows install the NDK on demand without needing a large Dockerfile.nvidia.Dockerfileandnvidia-bleeding-edge.Dockerfilewere used for CUDA/Vulkan benchmarks. New workflows rely on the drivers and software packages that are already installed on runners. We could have workflows install on demand or add new Dockerfiles as needed.