Skip to content

Commit

Permalink
Cleanup unused Dockerfiles and build_all.yml workflow. (#18222)
Browse files Browse the repository at this point in the history
Follow-up to #18144. Related to
#15332.

* `build_all.yml` was used as the first step in multiple other
workflows. New workflows are using `pkgci_build_packages.yml` directly
or nightly releases. Workflows could also use historical artifacts from
`pkgci_build_packages.yml` if they want to use versions different from
the nightly releases.
* `android.Dockerfile` was used for Android builds and benchmarks. New
workflows install the NDK on demand without needing a large Dockerfile.
* `nvidia.Dockerfile` and `nvidia-bleeding-edge.Dockerfile` were used
for CUDA/Vulkan benchmarks. New workflows rely on the drivers and
software packages that are already installed on runners. We could have
workflows install on demand or add new Dockerfiles as needed.
  • Loading branch information
ScottTodd authored Aug 14, 2024
1 parent 300af39 commit 00cc478
Show file tree
Hide file tree
Showing 10 changed files with 6 additions and 371 deletions.
124 changes: 0 additions & 124 deletions .github/workflows/build_all.yml

This file was deleted.

66 changes: 1 addition & 65 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,71 +79,6 @@ jobs:
gcr.io/iree-oss/base-bleeding-edge@sha256:cf2e78194e64fd0166f4141317366261d7a62432b72e9a324cb8c2ff4e1a515a \
./build_tools/bazel/build_test_all.sh
# Disabled while runner is offline.
# test_nvidia_a100:
# needs: [setup, build_all]
# if: contains(fromJson(needs.setup.outputs.enabled-jobs), 'test_nvidia_a100')
# env:
# BUILD_DIR: build-tests
# INSTALL_DIR: ${{ needs.build_all.outputs.install-dir }}
# INSTALL_DIR_ARCHIVE: ${{ needs.build_all.outputs.install-dir-archive }}
# INSTALL_DIR_GCS_URL: ${{ needs.build_all.outputs.install-dir-gcs-url }}
# IREE_CPU_DISABLE: 1
# IREE_VULKAN_DISABLE: 0
# IREE_CUDA_DISABLE: 0
# IREE_HIP_DISABLE: 1
# runs-on:
# - self-hosted # must come first
# - runner-group=${{ needs.setup.outputs.runner-group }}
# - environment=${{ needs.setup.outputs.runner-env }}
# - a100
# - os-family=Linux
# steps:
# - name: "Checking out repository"
# uses: actions/checkout@v4.1.7
# - name: "Checking out runtime submodules"
# run: ./build_tools/scripts/git/update_runtime_submodules.sh
# - name: Querying GPU information
# run: |
# ./build_tools/scripts/check_cuda.sh
# ./build_tools/scripts/check_vulkan.sh
# - name: "Downloading install dir archive"
# run: wget "${INSTALL_DIR_GCS_URL}" -O "${INSTALL_DIR_ARCHIVE}"
# - name: "Extracting install directory"
# run: tar -xf "${INSTALL_DIR_ARCHIVE}"
# - name: "Building tests"
# run: |
# ./build_tools/github_actions/docker_run.sh \
# --env IREE_CPU_DISABLE \
# --env IREE_VULKAN_DISABLE \
# --env IREE_CUDA_DISABLE \
# --env IREE_HIP_DISABLE \
# gcr.io/iree-oss/nvidia@sha256:433e072f075f90fdf07471673626b17091d8d8e2395626f1e6ac6c98803c8807 \
# ./build_tools/pkgci/build_tests_using_package.sh ${INSTALL_DIR}/bin
# - name: "Running GPU tests"
# env:
# IREE_CTEST_LABEL_REGEX: ^requires-gpu-sm80|^requires-gpu|^driver=vulkan$|^driver=cuda$
# IREE_NVIDIA_SM80_TESTS_DISABLE: 0
# IREE_MULTI_DEVICE_TESTS_DISABLE: 1
# run: |
# ./build_tools/github_actions/docker_run.sh \
# --env IREE_VULKAN_DISABLE \
# --env IREE_CUDA_DISABLE \
# --env IREE_HIP_DISABLE \
# --env IREE_CTEST_LABEL_REGEX \
# --env IREE_NVIDIA_SM80_TESTS_DISABLE \
# --env IREE_MULTI_DEVICE_TESTS_DISABLE \
# --env IREE_VULKAN_F16_DISABLE=0 \
# --env IREE_NVIDIA_GPU_TESTS_DISABLE=0 \
# --env CTEST_PARALLEL_LEVEL=4 \
# --env NVIDIA_DRIVER_CAPABILITIES=all \
# --gpus all \
# gcr.io/iree-oss/nvidia@sha256:433e072f075f90fdf07471673626b17091d8d8e2395626f1e6ac6c98803c8807 \
# bash -euo pipefail -c \
# "./build_tools/scripts/check_cuda.sh
# ./build_tools/scripts/check_vulkan.sh
# ./build_tools/cmake/ctest_all.sh ${BUILD_DIR}"

############################### Configurations ###############################
# Jobs that build IREE in some non-default configuration
##############################################################################
Expand Down Expand Up @@ -301,6 +236,7 @@ jobs:
##############################################################################

# Disabled to reduce self-hosted runners needed. See #17957
# TODO(#17957): migrate to pkgci
# cross_compile_and_test:
# needs: [setup, build_all]
# if: contains(fromJson(needs.setup.outputs.enabled-jobs), 'cross_compile_and_test')
Expand Down
19 changes: 0 additions & 19 deletions build_tools/docker/dockerfiles/android.Dockerfile

This file was deleted.

70 changes: 0 additions & 70 deletions build_tools/docker/dockerfiles/nvidia-bleeding-edge.Dockerfile

This file was deleted.

63 changes: 0 additions & 63 deletions build_tools/docker/dockerfiles/nvidia.Dockerfile

This file was deleted.

4 changes: 0 additions & 4 deletions build_tools/docker/manage_images.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,12 @@
IMAGES_TO_DEPENDENCIES = {
"base": [],
"base-arm64": [],
"android": ["base"],
"emscripten": ["base"],
"nvidia": ["base"],
"riscv": ["base"],
"riscv-toolchain-builder": [],
"samples": ["base"],
# Containers with all the newest versions of dependencies that we support
# instead of the oldest.
"base-bleeding-edge": [],
"nvidia-bleeding-edge": ["base-bleeding-edge"],
}

IMAGES_TO_DEPENDENT_IMAGES = {k: [] for k in IMAGES_TO_DEPENDENCIES}
Expand Down
3 changes: 0 additions & 3 deletions build_tools/docker/prod_digests.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
gcr.io/iree-oss/base@sha256:dc314b4fe30fc1315742512891357bffed4d1b62ffcb46258b1e0761c737b446
gcr.io/iree-oss/riscv@sha256:62e87bad3405d691ddba6f9be0ef44eeb60461a467c8d86f0842c81a1f97da79
gcr.io/iree-oss/nvidia@sha256:433e072f075f90fdf07471673626b17091d8d8e2395626f1e6ac6c98803c8807
gcr.io/iree-oss/emscripten@sha256:2dd4c52f1bb499ab365aad0111fe5538b685d88af38636b409b0cf6a576ab214
gcr.io/iree-oss/android@sha256:66b92a1c920588a73d03316f26025407ea754bab93e8f9bfe40dbf6ed5fe6c7e
gcr.io/iree-oss/base-bleeding-edge@sha256:cf2e78194e64fd0166f4141317366261d7a62432b72e9a324cb8c2ff4e1a515a
gcr.io/iree-oss/nvidia-bleeding-edge@sha256:a3b7b78c66c6fe3383b01c7662982c63f708637af1f92a7890b3256c2f178aa7
gcr.io/iree-oss/base-arm64@sha256:9daa1cdbbf12da8527319ece76a64d06219e04ecb99a4cff6e6364235ddf6c59
gcr.io/iree-oss/riscv-toolchain-builder@sha256:4240a374d35e5ea9037051559aaae4a8b6414ad5872501d4e240baccaacfff11
Loading

0 comments on commit 00cc478

Please sign in to comment.