Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs add -r /[path] does not see seem to upload complete data #5288

Closed
Miraj98 opened this issue Jul 26, 2018 · 2 comments · Fixed by #5365
Closed

ipfs add -r /[path] does not see seem to upload complete data #5288

Miraj98 opened this issue Jul 26, 2018 · 2 comments · Fixed by #5365
Assignees
@Stebalien
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Miraj98
Copy link

Miraj98 commented Jul 26, 2018

Whenever I run the command ipfs add -r /[path] the respective files seem to have been added but I also get a progress bar after adding all the files. The progress bar is never 100%. I just wanted to know if ipfs add command is working as intended.

Apples-MacBook-Pro:Desktop miraj$ ipfs add -r ./test/
added QmccaabqsYh2BpHSDo4ETbUVL9qXmbwyMb3PG84ghj3KGJ test/app.js
added Qmd5Pf3a6TwXcGRcRKELUAMHJdxj7wPNQQj93saJZQ9jhR test/index.html
added QmX5RYMxZQMoDFv6KyqUYfxkRaTbS4pvntSGEs7BUsnXCu test
 740 B / 868 B [==============================================>--------]  85.25%
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jul 26, 2018
@Stebalien Stebalien mentioned this issue Jul 26, 2018
Closed
@Stebalien
Copy link
Member

I've noticed a bug in how the commands library calculates file sizes that may be causing this. Once we merge ipfs/go-ipfs-cmdkit#24, I'll give you a branch you can try to see if it fixes this bug.

@Stebalien
Copy link
Member

Basically, we're telling the progress bar that there should be more data than there is. If that is the bug, then this is a harmless display bug.

Stebalien added a commit that referenced this issue Aug 10, 2018
@Stebalien
update cmdkit to fix the progress bar
af60037 
The progressbar should now correctly calculate the size of a directory (by
ignoring the directory sizes).

fixes #5288

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Aug 10, 2018
Merged
@ghost ghost assigned Stebalien Aug 10, 2018
@ghost ghost added the status/in-progress In progress label Aug 10, 2018
@Stebalien Stebalien mentioned this issue Aug 10, 2018
Open
Stebalien added a commit that referenced this issue Aug 11, 2018
@Stebalien
update cmdkit to fix the progress bar
f076936 
The progressbar should now correctly calculate the size of a directory (by
ignoring the directory sizes).

fixes #5288

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost removed the status/in-progress In progress label Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update cmdkit to fix the progress bar ipfs/kubo
2 participants
@Stebalien @Miraj98