Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test the progress bar on add #5366

Open
Stebalien opened this issue Aug 10, 2018 · 3 comments
Open

Test the progress bar on add #5366

Stebalien opened this issue Aug 10, 2018 · 3 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/test Testing work status/deferred Conscious decision to pause or backlog

Comments

@Stebalien
Copy link
Member

We currently have no progress bar tests. We should fix this. Specifically, I'd like to test #5288. When uploading a directory containing directories, the progress bar should reach 100%. We don't have to test the display, just the response from the server (may be best to parse the JSON? in bash? without jq?).
@Stebalien Stebalien added help wanted Seeking public contribution on this issue kind/test Testing work labels Aug 10, 2018
@Stebalien Stebalien mentioned this issue Aug 10, 2018
Merged
@daviddias daviddias added status/ready Ready to be worked exp/expert Having worked on the specific codebase is important labels Aug 12, 2018
@ngetahun
Copy link

ngetahun commented Sep 4, 2018

Is this issue up for grabs? I see the it's referenced in a PR, is the PR for this issue as well? If not, I would like to get started with this.

@Stebalien
Copy link
Member Author

It's still up for grabs. That was a PR fixing an issue in the progress bar while lamenting the lack of tests.

@ngetahun
Copy link

ngetahun commented Sep 6, 2018

Okay, I will give it a shot.

@Stebalien Stebalien added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/test Testing work status/deferred Conscious decision to pause or backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stebalien @daviddias @ngetahun