Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epoch types #2308

Closed
wants to merge 4 commits into from
Closed

Epoch types #2308

wants to merge 4 commits into from

Conversation

karimodm
Copy link
Contributor

Description of change

  • Epoch types and time<->epoch converstion facilities
  • DefaultGenesisTime moved to the epoch package: cyclic dependency with tangle

karimodm added 4 commits June 23, 2022 14:12
@karimodm
Remove EpochManager as it is completely stateless
b457ec0 
 Conflicts:
	packages/epoch/types.go
	packages/notarization/manager.go
	packages/notarization/proofs.go
	packages/tangle/timemanager.go
	packages/tangle/tipmanager.go
	plugins/messagelayer/notarization_plugin.go
@karimodm
Move DefaultGenesisTime to epoch package
f47ed65
@karimodm
Please doggo
c62b217
@karimodm
Remove *.orig files
0001a4a
@karimodm karimodm requested a review from hmoog June 23, 2022 12:21
@karimodm karimodm mentioned this pull request Jun 23, 2022
Merged
@karimodm karimodm changed the title Remove EpochManager as it is completely stateless Epoch types Jun 23, 2022
@karimodm
Copy link
Contributor Author

karimodm commented Jul 5, 2022

Changes are already in #2212

@karimodm karimodm closed this Jul 5, 2022
@karimodm karimodm deleted the feat/epoch-types branch July 8, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmoog hmoog Awaiting requested review from hmoog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karimodm