Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epoch Commitments #2212

Merged
merged 321 commits into from
Jul 5, 2022
Merged

Epoch Commitments #2212

merged 321 commits into from
Jul 5, 2022

Conversation

acha-bill
Copy link
Contributor

@acha-bill acha-bill commented May 18, 2022 •
edited by jkrvivian
Loading

Description of change

Finish #2129

This PR includes the implementation of:

  • epoch manager and epoch structures
  • epoch commitment factory and commitment, epoch commitment data structures
  • notarization manager
  • notarization plugin
  • branch rejected event

and the workflow as follow:
Notarization-registered events

Used by Message Factory:
Notarization-MessageFactory

Type of change

  • Breaking change

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@karimodm
Copy link
Contributor

karimodm commented May 20, 2022 •
edited
Loading

Structure and code look very good, awesome job!!!
There are a few misalignment with what we discussed at ReSum (the VM document is being reviewed), the new time concepts and the refactored UTXO VM: too many things are changing at once; we should strive to review and merge as much stuff as possible soon, so we can patch everything up and transition this PR out of draft mode!

Thanks guys!

daria305 and others added 25 commits June 3, 2022 17:17
@daria305
Change diff storage and update it on tx confirmation
acb4180
@daria305
Merge remote-tracking branch 'origin/feat/epoch-commitment' into feat…
832ee21 
…/epoch-commitment
@daria305
Fix snapshot errors after diff store changes
cd2ae61
@karimodm
Merge branch 'feat/epoch-commitment' of github.com:iotaledger/goshimm…
db7b3ee 
…er into feat/epoch-commitment

 Conflicts:
	packages/epoch/types.go
	packages/notarization/commitments.go
	packages/notarization/manager.go
	packages/notarization/storage.go
@karimodm
types fixes and storage
dc98c0f
@karimodm
Revert GetLatestEC
aeff4d9
@karimodm
Feat: Avoid storing transient UTXOs in epoch diffs #2251
d2a666d
@karimodm
Small fixes
2b259cc
@karimodm
Feat: some structures lifecycle
b191500
@karimodm
Better storage
fbef94f
@daria305
Update the structure
a6dd203
@daria305
Merge branch 'feat/epoch-commitment' into feat/update-ec-structure
cceb0b5
@georgysavva
Move epoch package inside ledger. Change OutputMetadata and EpochDiff…
fccd6ec 
… structs
@karimodm
Feat: structures lifecycle
4a7837f
@karimodm
Feat: proper getters and setters for storables
b6b7985
@karimodm
Add TODOs
947d77f
@daria305
Merge branch 'feat/epoch-commitment' into feat/update-ec-structure
08588d9 
# Conflicts:
#	packages/notarization/commitments.go
@karimodm
Merge remote-tracking branch 'origin/develop' into feat/epoch-commitment
b25558f 
 Conflicts:
	go.mod
	go.sum
	packages/ledger/testframework.go
	packages/tangle/message.go
	packages/tangle/message_test.go
	packages/tangle/messagefactory.go
	packages/tangle/tangle.go
	packages/tangle/tangle_test.go
	packages/tangle/testutils.go
	plugins/core.go
	tools/integration-tests/tester/framework/parameters.go
@karimodm
Fix: using new models after merge
87f9a51
@karimodm
Fix: no compile errors
da505cd
@karimodm
Fix: storage nil pointer dereference
bb51d3e
@daria305
Add commitments progressing when delayed
fc8307d
@daria305
Merge branch 'feat/epoch-commitment' into feat/update-ec-structure
42ffd22
@jkrvivian
Add comments to exported methods
6b0cf8a
@karimodm
Only have one MinMana threshold
cd1e8b5
karimodm and others added 18 commits June 30, 2022 12:03
@karimodm
Fix integration tests
a21f832
@karimodm
Lock EpochCommittmentFactory upon OnAcceptanceTimeUpdated
1dd5ee0
@karimodm
ReadLock on GetLatestEC
a961773
@karimodm
Remove slow prints
264a437
@karimodm
Fresh GenesisTime
63afe2c
@karimodm
CMana calculation is now anchored to epochs
0a4a2d9
@daria305
Fix: Set output pledgeID in booker
6ad7364
@daria305
Merge remote-tracking branch 'origin/feat/add-epoch-committable-even'…
ff23c90 
… into feat/add-epoch-committable-even
@daria305
Fix: Set output pledgeID in booker
667f982
@daria305
WIP mana tests
0edcfed
@daria305
Merge remote-tracking branch 'origin/feat/add-epoch-committable-even'…
9dea252 
… into feat/add-epoch-committable-even
@daria305
Fix: Set output pledgeID in booker
5ef6ddb
@daria305
Fix access mana pledge
f73b82d
@karimodm
Fix invalid cast from MockedTransaction when storing outputs
e76f877
@karimodm
Code quality
8cc356d
@karimodm
Remove slow prints
26655e3
@karimodm
Introduce messageLayer.GenesisTime to reset genesis time on tests
c547a12
@karimodm
Merge pull request #2312 from iotaledger/feat/add-epoch-committable-even
981634d
@karimodm karimodm changed the title Feat/epoch commitment Epoch Commitments Jul 4, 2022
@karimodm karimodm marked this pull request as ready for review July 4, 2022 14:02
@karimodm karimodm requested review from piotrm50 and removed request for karimodm July 4, 2022 14:35
@karimodm karimodm merged commit abde9b0 into develop Jul 5, 2022
@karimodm karimodm deleted the feat/epoch-commitment branch July 5, 2022 08:19
@karimodm karimodm mentioned this pull request Jul 5, 2022
Closed
This was referenced Jul 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daria305 daria305 daria305 left review comments

@jkrvivian jkrvivian jkrvivian approved these changes

@jonastheis jonastheis Awaiting requested review from jonastheis

@hmoog hmoog Awaiting requested review from hmoog

@piotrm50 piotrm50 Awaiting requested review from piotrm50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acha-bill @karimodm @jkrvivian @daria305 @georgysavva