Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: updated GitHub action to make reviewdog compatible with "new-from-rev" option #1142

Merged
merged 13 commits into from
Mar 27, 2021
Merged

Fix: updated GitHub action to make reviewdog compatible with "new-from-rev" option #1142

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b013313
Fix: fix golantci lint
Mar 27, 2021
2d9b4e8
Refactor: removed git from rev which fails in an action
Mar 27, 2021
5c4d50d
Refactor: blub
Mar 27, 2021
cb09a45
Refactor: add error
Mar 27, 2021
8bb2aa6
Refactor: reverted intentional error
Mar 27, 2021
a519228
Refactor: refactor golangci.yml
Mar 27, 2021
41bf910
Refactor: added error again
Mar 27, 2021
224808d
Refactor: changed bug
Mar 27, 2021
74e5398
Refactor: make git fetch more
Mar 27, 2021
8ace1c3
Refactor: created error
Mar 27, 2021
d8c94b9
Fix: fixed settings
Mar 27, 2021
c75fa85
Fix: fixed bug
Mar 27, 2021
4472ea2
Refactor: added comment for option
Mar 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/reviewdog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ jobs:

- name: Checkout repository
uses: actions/checkout@v2
with:
fetch-depth: 0

- uses: actions/setup-go@v2
with:
go-version: "^1.16.2"

- name: Run golangci-lint # reviewdog v1.19.0, golangci-lint v1.38.0
uses: reviewdog/action-golangci-lint@93be4324306dcbba508544d891a7b0576bb28ddd
Expand Down
2 changes: 1 addition & 1 deletion packages/markers/sequence.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ func (s SequenceIDs) Alias() (aggregatedSequencesID SequenceAlias) {
return
}

// Bytes returns a marshaled version of the SequenceIDs.
// Bytes0sssg returns a marshaled version of the SequenceIDs.
hmoog marked this conversation as resolved.
Show resolved Hide resolved
func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) {
marshalUtil := marshalutil.New()
marshalUtil.WriteUint32(uint32(len(s)))
Expand Down