Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: updated GitHub action to make reviewdog compatible with "new-from-rev" option #1142

Merged
merged 13 commits into from
Mar 27, 2021

Conversation

hmoog
Copy link
Contributor

@hmoog hmoog commented Mar 27, 2021

Description of change

GitHub only checks out the committed revision when using checkout@v2. This prevents golangci-lint to use the new-from-rev option since the revision to compare to does not exist. This PR configures checkout to pull all revisions.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hmoog hmoog changed the title Fix/golint Fix: updated GitHub action to make reviewdog compatible with "new-from-rev" option Mar 27, 2021
@hmoog hmoog merged commit 1a17f96 into develop Mar 27, 2021
@hmoog hmoog deleted the fix/golint branch March 27, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants