Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ServerRelativeArchivalRedirect easier to extend #57

Closed
kngenie opened this issue Jan 20, 2015 · 2 comments
Closed

Make ServerRelativeArchivalRedirect easier to extend #57

kngenie opened this issue Jan 20, 2015 · 2 comments
Assignees
@kngenie
Labels
enhancement

Comments

@kngenie
Copy link
Member

kngenie commented Jan 20, 2015

Archive-It found a issue with Referer header generated by Flash plugin for Firefox (ARI-4169) and wants to extend ServerRelativeArchivalRedirect with supplemental method for obtaining ArchivalUrl context. As the method depends on private JavaScript library it uses, we'd like to keep the enhancement local to Archive-It, for now. Unfortunately ServerRelativeArchivalRedirect does not have extension point to enable this.

Plan is to move the code in ServerRelativeArchivalRedirect that parses Referer into a new method, so that sub-class can override it.
@kngenie kngenie self-assigned this Jan 20, 2015
@kngenie kngenie changed the title Change ServerRelativeArchivalRedirect to make it easier to extend Make ServerRelativeArchivalRedirect easier to extend Jan 20, 2015
kngenie added a commit that referenced this issue Jan 27, 2015
@kngenie
Move Referer header parsing to a method for easier customization.
955ccd2 
Change for issue #57.
@kngenie kngenie mentioned this issue Jan 30, 2015
Closed
@kngenie
Copy link
Member Author

kngenie commented Mar 16, 2016

Done: 06f71e6
Merged to master: 41517a9

kngenie added a commit that referenced this issue Mar 16, 2016
@kngenie
Move Refer header field parsing in ServerRelativeArchivalRedirect to …
7da92ee 
…a method for easier customization.

Cherry-picked:
- 955ccd2
- 06f71e6
See also: #57
@kngenie kngenie mentioned this issue Mar 16, 2016
Merged
@kngenie
Copy link
Member Author

kngenie commented Mar 16, 2016

submitted a pull request. closing.

@kngenie kngenie closed this as completed Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kngenie kngenie

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kngenie