Move Referer header field parsing in ServerRelativeArchivalRedirect to a method for easier customization #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks works for me. 👍 I will merge it with modified release_notes.md, since the version has changed at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue with
Refererheader generated by Flash plugin for Firefox and want to extendServerRelativeArchivalRedirectwith experimental method of obtaining ArchivalUrl context. UnfortunatelyServerRelativeArchivalRedirectdoes not have extension point for this purpose.This patch separates out
Refererparsing inhandleRequestWithCollectioninto a protected method, so that developer can extend ServerRelativeArchivalRedirect with experimental leak-source detection mechanism.See also: internetarchive#57