feat(backend): unauthenticated get incoming payment (#1952) #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlairCurrey
reviewed
Oct 18, 2023
openapi/resource-server.yaml
Outdated
Comment on lines
617
to
614
| anyOf: | ||
| - $ref: '#/components/schemas/incoming-payment-with-connection' | ||
| - $ref: '#/components/schemas/public-incoming-payment' |
There was a problem hiding this comment.
This is an old version of the spec. I guess we should leave this as-is but refetch the spec on nl-open-payments-updates after this is merged in?
There was a problem hiding this comment.
I think I'm going to just re-fetch on this branch first before merging it in.
BlairCurrey
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Somehow routes.test.ts is not deleted here but was deleted in https://github.com/interledger/rafiki/pull/1940/files. I noticed this when checking the changes files here against the original PR's. It is removed in #2051
Not sure if we need to do anything about it here, but just a reminder that it can be deleted from the dev branch if it's there after we merge this/these PR's.
BlairCurrey
approved these changes
Oct 18, 2023
- remove connections route from open payments spec - remove connections route and any associated service functions from backend
* feat(backend): mount resource server routes explicitly * chore: formatting * feat(backend): wip unauthenticated incoming payment get * fix(backend): token introspection middleware * chore(backend): cleanup * chore(backend): cleanup * test(backend): update incoming payment tests * test(backend): add tests for new option * feat(backend): add unauthed incoming payment * fix: accidentally removed postman request * refactor(backend): optional sig params * fix(backend): typo * fix(backend): unused args --------- Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>
dd81b1c to
05fc189
Compare
njlie
added a commit
that referenced
this pull request
Oct 23, 2023
sabineschaller
added a commit
that referenced
this pull request
Oct 26, 2023
* feat(backend): rename "payment pointer" tables & columns to use "wallet address" (#1937) Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local> * feat(backend, mock-ase): rename payment pointer to wallet address in rafiki code (#2029) * fix(backend): rename paymentPointerId column in combinedPaymentsView to walletAddressId (#2043) * docs: replace payment pointer with wallet address (#1951) * feat(backend): remove connections route (#1940) (#2051) Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev> * feat(backend): unauthenticated get incoming payment (#1952) (#2052) Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev> Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com> * feat(auth): fix auth tests for access tokens (#2053) * feat(backend): remove payment pointer from url, retrieve it from request query or body (#2042) * refactor(backend): swap connection for methods (#2054) Co-authored-by: Nathan Lie <lie4nathan@gmail.com> * fix(backend): resolve breaking build after main rebase (#2085) * fix(backend): combined_payment, ilp service tests (#2094) * fix(backend): combined_payment, ilp service tests * chore(backend): format * fix(backend): bad test refactor * fix(postman): invalid json (#2096) * fix: fetch walletAddress graph in quote and outgoing payment service (#2099) * fix(postman): env var usage (#2107) * feat(backend): add quotes route to exceptions in wallet address middleware (#2108) * chore: formatting * fix(backend): fix GET /incoming-payments (#2111) * fix(backend): remove wallet address from OP response id and fix receiver service (#2115) * fix: remove wallet address from op resource urls * feat: return auth server url in public incoming payment and fix receiver service * fix: quote issue * fix: walletAddress middleware * chore: update postman * fix: listing * chore: remove console.log * fix: progress towards making listing work * fix(backend): fix create remote incoming payment (#2121) * fix(postman): misc postman fixes * fix(postman): complete incoming payment (#2126) * fix: file name correction (#2127) * fix: GET resource lists, use op client (#2122) * fix(postman): update list urls * fix(openapi): rm defaults for first, last * refactor(postman): query param order for readability * fix(backend): update to new open-payments pkgs * fix(backend): use op client to get authServer * fix(backend): rm old code * fix(backend): receiver tests * chore: cleanup * feat: make list query parameter configurable * chore: update OP package and fix types --------- Co-authored-by: Sabine Schaller <sabine@interledger.org> * fix(postman): additional fixes * fix: wallet address on the fly creation (#2129) * chore: update postman environments * Postman: update description for P2P example * Postman: Remove finalizationReason from getGrants API + fix createWalletAddress * chore: bump open-payments package in auth * chore: update last few remaining mentions of payment pointers * chore(postman): remove references to payment pointer * chore: update another reference to pp --------- Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local> Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev> Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com> Co-authored-by: Sabine Schaller <sabine@interledger.org> Co-authored-by: Sarah Jones <sarah38186@gmail.com> Co-authored-by: Max Kurapov <maxkurapov@gmail.com> Co-authored-by: Max Kurapov <max@interledger.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from backend
Changes proposed in this pull request
Context
This is the same as #1940, but with some rebasing work.
Somehow, during the maintenance of nl-open-payments to be kept up to date with main, this commit was lost. This PR will re-introduce the changes.
(Re-)Fixes #1910
Checklist
fixes #number