Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): unauthenticated get incoming payment #1952

Merged
merged 16 commits into from
Sep 25, 2023
Merged

feat(backend): unauthenticated get incoming payment #1952

merged 16 commits into from
Sep 25, 2023

Conversation

BlairCurrey
Copy link
Contributor

@BlairCurrey BlairCurrey commented Sep 21, 2023 •
edited
Loading

Changes proposed in this pull request

  • adds unauthenticated version of the incoming-payments route
  • makes new middleware to set authentication status and switch between authed/unauthed gets
  • modifies token introspection middleware to not throw on failure (for this route only) via new bypassErrorsoption
    • token introspection still needs to happen (otherwise I just wouldn't use it on this route) because it sets info on the context which is required in case valid auth details are provided

Context

fixes: #1896
fixes: #1910

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Postman collection updated

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Sep 21, 2023
njlie
njlie reviewed Sep 22, 2023
View reviewed changes
BlairCurrey
BlairCurrey commented Sep 22, 2023
View reviewed changes
openapi/resource-server.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan on pulling in the latest open-payments spec when we do the open-payments release. Leaving these for now as it is required to run/tests.

@BlairCurrey BlairCurrey marked this pull request as ready for review September 22, 2023 09:17
@BlairCurrey BlairCurrey merged commit 18a4db3 into nl-open-payments-updates Sep 25, 2023
@BlairCurrey BlairCurrey deleted the bc/1896/unauthenticated-get-incoming-payment branch September 25, 2023 16:02
@BlairCurrey BlairCurrey mentioned this pull request Sep 26, 2023
Closed
@BlairCurrey BlairCurrey linked an issue Sep 26, 2023 that may be closed by this pull request
Update Rafiki backend to allow for an unauthenticated GET /incoming-payments/:id request #1910
Closed
@BlairCurrey BlairCurrey linked an issue Sep 26, 2023 that may be closed by this pull request
Non-authenticated GET Incoming payment request #1896
Closed
2 tasks
@BlairCurrey BlairCurrey mentioned this pull request Sep 26, 2023
Closed
2 tasks
njlie pushed a commit that referenced this pull request Oct 12, 2023
@BlairCurrey @njlie
feat(backend): unauthenticated get incoming payment (#1952)
c3c37a5 
* feat(backend): mount resource server routes explicitly

* chore: formatting

* feat(backend): wip unauthenticated incoming payment get

* fix(backend): token introspection middleware

* chore(backend): cleanup

* chore(backend): cleanup

* test(backend): update incoming payment tests

* test(backend): add tests for new option

* feat(backend): add unauthed incoming payment

* fix: accidentally removed postman request

* refactor(backend): optional sig params

* fix(backend): typo

* fix(backend): unused args

---------

Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>
njlie pushed a commit that referenced this pull request Oct 12, 2023
@BlairCurrey @njlie
feat(backend): unauthenticated get incoming payment (#1952)
e9da4d5 
* feat(backend): mount resource server routes explicitly

* chore: formatting

* feat(backend): wip unauthenticated incoming payment get

* fix(backend): token introspection middleware

* chore(backend): cleanup

* chore(backend): cleanup

* test(backend): update incoming payment tests

* test(backend): add tests for new option

* feat(backend): add unauthed incoming payment

* fix: accidentally removed postman request

* refactor(backend): optional sig params

* fix(backend): typo

* fix(backend): unused args

---------

Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>
njlie pushed a commit that referenced this pull request Oct 18, 2023
@BlairCurrey @njlie
feat(backend): unauthenticated get incoming payment (#1952)
038d6a0 
* feat(backend): mount resource server routes explicitly

* chore: formatting

* feat(backend): wip unauthenticated incoming payment get

* fix(backend): token introspection middleware

* chore(backend): cleanup

* chore(backend): cleanup

* test(backend): update incoming payment tests

* test(backend): add tests for new option

* feat(backend): add unauthed incoming payment

* fix: accidentally removed postman request

* refactor(backend): optional sig params

* fix(backend): typo

* fix(backend): unused args

---------

Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>
njlie pushed a commit that referenced this pull request Oct 18, 2023
@BlairCurrey @njlie
feat(backend): unauthenticated get incoming payment (#1952)
de89979 
* feat(backend): mount resource server routes explicitly

* chore: formatting

* feat(backend): wip unauthenticated incoming payment get

* fix(backend): token introspection middleware

* chore(backend): cleanup

* chore(backend): cleanup

* test(backend): update incoming payment tests

* test(backend): add tests for new option

* feat(backend): add unauthed incoming payment

* fix: accidentally removed postman request

* refactor(backend): optional sig params

* fix(backend): typo

* fix(backend): unused args

---------

Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>
njlie added a commit that referenced this pull request Oct 18, 2023
@njlie @BlairCurrey
feat(backend): unauthenticated get incoming payment (#1952) (#2052)
2bba62b 
Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev>
Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com>
BlairCurrey added a commit that referenced this pull request Oct 18, 2023
@BlairCurrey
feat(backend): unauthenticated get incoming payment (#1952)
d61f584 
* feat(backend): mount resource server routes explicitly

* chore: formatting

* feat(backend): wip unauthenticated incoming payment get

* fix(backend): token introspection middleware

* chore(backend): cleanup

* chore(backend): cleanup

* test(backend): update incoming payment tests

* test(backend): add tests for new option

* feat(backend): add unauthed incoming payment

* fix: accidentally removed postman request

* refactor(backend): optional sig params

* fix(backend): typo

* fix(backend): unused args

---------

Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>
njlie added a commit that referenced this pull request Oct 23, 2023
@njlie @BlairCurrey
feat(backend): unauthenticated get incoming payment (#1952) (#2052)
7cb532b 
Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev>
Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com>
sabineschaller added a commit that referenced this pull request Oct 26, 2023
@njlie @BlairCurrey
@sabineschaller @JoblersTune @mkurapov
feat(backend, frontend, auth, mock-ase): update open payments (#2075)
5ea0f7d 
* feat(backend): rename "payment pointer" tables & columns to use "wallet address" (#1937)

Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>

* feat(backend, mock-ase): rename payment pointer to wallet address in rafiki code (#2029)

* fix(backend): rename paymentPointerId column in combinedPaymentsView to walletAddressId (#2043)

* docs: replace payment pointer with wallet address (#1951)

* feat(backend): remove connections route (#1940) (#2051)

Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev>

* feat(backend): unauthenticated get incoming payment (#1952) (#2052)

Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev>
Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com>

* feat(auth): fix auth tests for access tokens (#2053)

* feat(backend): remove payment pointer from url, retrieve it from request query or body (#2042)

* refactor(backend): swap connection for methods (#2054)

Co-authored-by: Nathan Lie <lie4nathan@gmail.com>

* fix(backend): resolve breaking build after main rebase (#2085)

* fix(backend): combined_payment, ilp service tests (#2094)

* fix(backend): combined_payment, ilp service tests

* chore(backend): format

* fix(backend): bad test refactor

* fix(postman): invalid json (#2096)

* fix: fetch walletAddress graph in quote and outgoing payment service (#2099)

* fix(postman): env var usage (#2107)

* feat(backend): add quotes route to exceptions in wallet address middleware (#2108)

* chore: formatting

* fix(backend): fix GET /incoming-payments (#2111)

* fix(backend): remove wallet address from OP response id and fix receiver service (#2115)

* fix: remove wallet address from op resource urls

* feat: return auth server url in public incoming payment and fix receiver service

* fix: quote issue

* fix: walletAddress middleware

* chore: update postman

* fix: listing

* chore: remove console.log

* fix: progress towards making listing work

* fix(backend): fix create remote incoming payment (#2121)

* fix(postman): misc postman fixes

* fix(postman): complete incoming payment (#2126)

* fix: file name correction (#2127)

* fix: GET resource lists, use op client (#2122)

* fix(postman): update list urls

* fix(openapi): rm defaults for first, last

* refactor(postman): query param order for readability

* fix(backend): update to new open-payments pkgs

* fix(backend): use op client to get authServer

* fix(backend): rm old code

* fix(backend): receiver tests

* chore: cleanup

* feat: make list query parameter configurable

* chore: update OP package and fix types

---------

Co-authored-by: Sabine Schaller <sabine@interledger.org>

* fix(postman): additional fixes

* fix: wallet address on the fly creation (#2129)

* chore: update postman environments

* Postman: update description for P2P example

* Postman: Remove finalizationReason from getGrants API + fix createWalletAddress

* chore: bump open-payments package in auth

* chore: update last few remaining mentions of payment pointers

* chore(postman): remove references to payment pointer

* chore: update another reference to pp

---------

Co-authored-by: Nathan Lie <nathanlie@Nathans-MacBook-Pro.local>
Co-authored-by: Ömer Talha Özdemir <omer@fynbos.dev>
Co-authored-by: Blair Currey <12960453+BlairCurrey@users.noreply.github.com>
Co-authored-by: Sabine Schaller <sabine@interledger.org>
Co-authored-by: Sarah Jones <sarah38186@gmail.com>
Co-authored-by: Max Kurapov <maxkurapov@gmail.com>
Co-authored-by: Max Kurapov <max@interledger.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlie njlie njlie approved these changes

@omertoast omertoast Awaiting requested review from omertoast

@mkurapov mkurapov Awaiting requested review from mkurapov

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
2 participants
@BlairCurrey @njlie