chore: make estimatedExchangeRate nullable (for now) #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
mkurapov
commented
Oct 17, 2023
| Number(fees) * quote.estimatedExchangeRate.valueOf() | ||
| ) | ||
| const estimatedExchangeRate = | ||
| quote.estimatedExchangeRate || quote.lowEstimatedExchangeRate.valueOf() |
There was a problem hiding this comment.
Fallback to lowEstimatedExchangeRate (until #2000)
BlairCurrey
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
packages/backend/migrations/20230927223235_make_quotes_generic.jsmigration if there is existing data, when trying to create a non-nullableestimatedExchangeRate. Fixing toestimatedExchangeRatein table to be nullable until Migrate ILP-related data in DB tables to be more method-agnostic #2000 is being worked onContext
Related to #1967
Checklist
fixes #number