Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "payment method handler" service, that abstracts away quoting & paying #1967

Closed
2 of 4 tasks
Tracked by #1965
mkurapov opened this issue Sep 28, 2023 · 0 comments · Fixed by #2031
Closed
2 of 4 tasks
Tracked by #1965

Create "payment method handler" service, that abstracts away quoting & paying #1967

mkurapov opened this issue Sep 28, 2023 · 0 comments · Fixed by #2031
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Sep 28, 2023

In order to be able to support multiple payment methods, we need a service that knows how to do quoting and transfers without having the callers of the service (QuoteService, OutgoingPaymentService) know exactly about the details of how quoting and paying are done for different payment methods.

Tasks

  • Introduce "payment method handler" service that abstracts away quoting and paying
  • Have quoteService.createQuote call the "payment manager" service "getQuote" method
  • Move ILP quoting & transfers into own service
  • Have outgoingPaymentService call the "payment manager" service "pay" method
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Sep 28, 2023
@sabineschaller sabineschaller added this to the v1.0.0-alpha.4 milestone Oct 3, 2023
@mkurapov mkurapov changed the title Create PaymentManager service, that abstracts away quoting & paying Create "payment method handler" service, that abstracts away quoting & paying Oct 3, 2023
@mkurapov mkurapov self-assigned this Oct 13, 2023
@mkurapov mkurapov moved this from Backlog to In Progress in Rafiki Oct 13, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Rafiki Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants