refactor: update shutdown process #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mkurapov
commented
Sep 1, 2023
Comment on lines
+209
to
+210
| connectorApp: Promise<ConnectorApp> | ||
| tigerbeetle: Promise<TigerbeetleClient> |
There was a problem hiding this comment.
adds these services so they are properly typed when doing container.use
mkurapov
commented
Sep 1, 2023
|
|
||
| export interface AppContextData { | ||
| logger: Logger | ||
| closeEmitter: EventEmitter |
mkurapov
commented
Sep 1, 2023
Comment on lines
-458
to
-460
| await tigerbeetle.destroy() | ||
| tigerbeetle.destroy() | ||
| const redis = await container.use('redis') | ||
| await redis.disconnect() |
There was a problem hiding this comment.
not async functions
mkurapov
commented
Sep 1, 2023
| @@ -37,6 +37,6 @@ export class OutgoingIlpPlugin implements IlpPlugin { | |||
| } | |||
|
|
|||
| export interface IlpPluginOptions { | |||
| sourceAccount: LiquidityAccount | |||
| sourceAccount: ConnectorAccount | |||
There was a problem hiding this comment.
updating to the the correct type
mkurapov
commented
Sep 6, 2023
| @@ -158,12 +152,12 @@ export class App { | |||
| }) | |||
|
|
|||
| // Setup Apollo | |||
| this.apolloServer = new ApolloServer({ | |||
| const apolloServer = new ApolloServer({ | |||
There was a problem hiding this comment.
this.apolloServer wasn't used outside of this function
sabineschaller
approved these changes
Sep 6, 2023
raducristianpopa
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
index.tsapp.shutdownfunction to properly close all running servers (in bothauthandbackendpackages)closeEmitterContext
Related to: #1805 (comment)
Checklist
fixes #number