feat: get peering details #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
Comment on lines
500
to
501
| public async shutdown(): Promise<void> { | ||
| return new Promise((resolve): void => { |
There was a problem hiding this comment.
I'm a little bit confused by this. Why is the promise getting resolved multiple times instead of just once? If there is an OP server, wouldn't the promise be resolved in that specific if block, making any further resolves irrelevant?
There was a problem hiding this comment.
I've been trying to update this code, but it's behaving weirdly when I update it to be "correct". I wonder why it was built this way originally, tbh.
I'm going to make a separate PR that hopefully fixes this and makes it more clear
raducristianpopa
approved these changes
Sep 1, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Start of auto-peering story. Adding GET route for returning peering details (for peering discoverability). The new server instantiation itself is under a flag (defaults OFF)
Fixes #1763
Checklist
fixes #number